Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure service principal credentials #1377

Merged
merged 7 commits into from
May 25, 2024

Conversation

steinitzu
Copy link
Collaborator

Description

Adds support for authenticating Azure with service principal (client ID/secret/tenant ID):

[destination.filesystem]
bucket_url = "az://[your_container name]" # replace with your container name

[destination.filesystem.credentials]
azure_client_id = "client_id" # please set me up!
azure_client_secret = "client_secret
azure_tenant_id = "tenant_id" # please set me up!

Related Issues

Additional Context

Copy link

netlify bot commented May 16, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 1f4c24d
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6651d153dab63e0008d2bf6c
😎 Deploy Preview https://deploy-preview-1377--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steini LGTM

just one thing: ping me on Slack and let's add test credentials to the vault and please write a test that just connects to out accounts and does a few ops. you can use our fsspec abstraction to do that

@steinitzu steinitzu force-pushed the azure-service-principal-credentials branch 2 times, most recently from 1586d02 to c031717 Compare May 22, 2024 23:00
@rudolfix rudolfix force-pushed the azure-service-principal-credentials branch from a5cc04f to 1f4c24d Compare May 25, 2024 11:53
@rudolfix rudolfix merged commit 3dc1874 into devel May 25, 2024
49 of 50 checks passed
@rudolfix rudolfix deleted the azure-service-principal-credentials branch May 25, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tenant Id Authentication to the Azure Blob Storage client
2 participants