Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Filesystem Documentation: Handling Deeply Nested JSON #1385

Closed
wants to merge 6 commits into from

Conversation

dat-a-man
Copy link
Collaborator

This PR updates the filesystem documentation to include instructions for handling deeply nested JSON files by enabling automatic directory creation.
Changes:

Documentation Update:

  • Provided instructions for setting kwargs = '{"auto_mkdir": true}' in config.toml.
  • Included steps for setting kwargs using environment variables.

rudolfix and others added 2 commits May 14, 2024 17:21
* Add an example for post paginators

* update the example cursor key

* Update docs/website/docs/general-usage/http/rest-client.md

Co-authored-by: VioletM <[email protected]>

* Update docs/website/docs/general-usage/http/rest-client.md

Co-authored-by: VioletM <[email protected]>

* Update docs/website/docs/general-usage/http/rest-client.md

* Add rest_api verified source documentation (#1308)

* Add rest_api source docs

* Expand rest_api documentation

* Update snippets

* Update string aliases

* Link dlt source

* Reordered code in the example and added a new section

* Mention auto detection

* Reorder the sentence about paginator types and instances

* Elaborate on dependent resources; link the transformer docs

* Link incremental loading

* Update the example to use rest_api_resources

* Rename github_config

---------

Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: VioletM <[email protected]>
@dat-a-man dat-a-man requested a review from VioletM May 20, 2024 05:00
Copy link

netlify bot commented May 20, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit c254bd5
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/665082780d12d500086cc253
😎 Deploy Preview https://deploy-preview-1385--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sh-rp sh-rp added the documentation Improvements or additions to documentation label May 21, 2024
dat-a-man and others added 2 commits May 23, 2024 13:53
* Added blogpost

* Updated Anuun's comments.

* Updated "docs/website/docs/dlt-ecosystem/verified-sources/rest_api.md"

* updated docs/examples/custom_destination_bigquery/custom_destination_bigquery.py
kwargs = '{"auto_mkdir": true}'
```

To set using environment variables:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to the tip above (line 362)

@@ -371,6 +371,14 @@ To configure the layout and placeholders using `config.toml`, use the following
layout = "{table_name}/{test_placeholder}/{YYYY}-{MM}-{DD}/{ddd}/{mm}/{load_id}.{file_id}.{ext}"
extra_placeholders = { "test_placeholder" = "test_value" }
current_datetime="2024-04-14T00:00:00"
# for deeply nested layouts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# for deeply nested layouts
# for automatic directory creation in the local filesystem

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@dat-a-man dat-a-man force-pushed the docs/update_filesystem_docs branch from 1762f09 to 9225803 Compare May 24, 2024 11:55
@AstrakhantsevaAA
Copy link
Contributor

@dat-a-man, you trying to merge changes from master to devel, you don;'t need to do that. Which branch did your branch originate from master or devel?

@VioletM VioletM closed this May 27, 2024
@dat-a-man dat-a-man deleted the docs/update_filesystem_docs branch June 15, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants