Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1272 Support ClickHouse GCS S3 compatibility mode in filesystem destination #1423

Conversation

Pipboyguy
Copy link
Collaborator

Description

Updates the filesystem destination to support using the S3 implementation with GCS buckets that have S3 interoperability mode (HMAC keys) enabled.

Key changes:

  • Update convert_storage_to_http_scheme utility function to properly handle GCS endpoints
  • Modify ClickHouse load job to raise an exception if GCS bucket is used without providing S3 compatible credentials (access key ID and secret access key)
  • Add test case to verify ClickHouse loading from GCS bucket using S3 compatibility mode
  • Remove old gcs tests. These will be added back in when named destinations are supported in templated tests.

Related Issues

@Pipboyguy Pipboyguy self-assigned this May 28, 2024
@Pipboyguy Pipboyguy linked an issue May 28, 2024 that may be closed by this pull request
@Pipboyguy Pipboyguy requested review from sh-rp and rudolfix May 28, 2024 18:19
Copy link

netlify bot commented May 28, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 9a58f8f
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66587cd5d6613a0008b05569
😎 Deploy Preview https://deploy-preview-1423--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pipboyguy Pipboyguy added bug Something isn't working documentation Improvements or additions to documentation destination Issue related to new destinations labels May 28, 2024
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: LGTM!
@Pipboyguy do we have the right credentials in our CI so this test is really connecting to clickhouse?

@sh-rp you should review this

@sh-rp
Copy link
Collaborator

sh-rp commented May 30, 2024

code: LGTM! @Pipboyguy do we have the right credentials in our CI so this test is really connecting to clickhouse?

Yeah I put those in yesterday. The question you were asking was wether it is really connecting to GCS, right?

@Pipboyguy
Copy link
Collaborator Author

code: LGTM! @Pipboyguy do we have the right credentials in our CI so this test is really connecting to clickhouse?

@sh-rp you should review this

@rudolfix We are indeed connecting to GCS with HMAC credentials and test passes

@Pipboyguy Pipboyguy requested a review from sh-rp May 30, 2024 13:19
@sh-rp sh-rp merged commit 9f17a21 into devel Jun 3, 2024
48 of 50 checks passed
@rudolfix rudolfix deleted the 1272-make-filesystem-destination-work-with-gcs-in-s3-compatibility-mode branch June 3, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working destination Issue related to new destinations documentation Improvements or additions to documentation
Projects
Status: Done
3 participants