-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1272 Support ClickHouse GCS S3 compatibility mode in filesystem destination #1423
1272 Support ClickHouse GCS S3 compatibility mode in filesystem destination #1423
Conversation
Signed-off-by: Marcel Coetzee <[email protected]>
This reverts commit cb80c6b.
Signed-off-by: Marcel Coetzee <[email protected]>
…use" This reverts commit f24eb1d.
…orted Signed-off-by: Marcel Coetzee <[email protected]>
…-destination-work-with-gcs-in-s3-compatibility-mode
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
…gcs-in-s3-compatibility-mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code: LGTM!
@Pipboyguy do we have the right credentials in our CI so this test is really connecting to clickhouse?
@sh-rp you should review this
Yeah I put those in yesterday. The question you were asking was wether it is really connecting to GCS, right? |
Signed-off-by: Marcel Coetzee <[email protected]>
@rudolfix We are indeed connecting to GCS with HMAC credentials and test passes |
Description
Updates the filesystem destination to support using the S3 implementation with GCS buckets that have S3 interoperability mode (HMAC keys) enabled.
Key changes:
convert_storage_to_http_scheme
utility function to properly handle GCS endpointsRelated Issues
GcpCredentials
#1181