-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies to fix bug on databricks has_dataset #1436
update dependencies to fix bug on databricks has_dataset #1436
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @oonyoontong , thanks for the contribution. I have a few comments/questions, so please take a look :)
955eabc
to
39779e9
Compare
sorry for the messy PR @steinitzu, was planning clean it up today. The PR was done early to let the others facing this issue that it was being actively worked on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! So this is due to an incompatibility with latest pandas databricks/databricks-sql-python#326
Latest connector pins pandas version, so updating is good imo and we should do it anyway.
The only problem is that the named paramstyle fails with a confusing error on cluster runtime version 13.x
for some reason. I had to upgrade the test cluster to 14.3
.
If there's no way around that I think we should try to detect which version is running at the beginning of has_dataset
. I.e. https://docs.databricks.com/en/sql/language-manual/functions/current_version.html
And raise a DatabaseTerminalException
with a helpful message.
What do you think?
from my investigation of
I am more inclined to catch the I dont have the ability to change my databricks cluster to 13.x to test named paramstyle error returned, if you think the above solution works, could you help me add a commit to except the |
let me know how i can expedit this, this is a huge blocker for us |
Alright, @oonyoontong . Thanks for looking into this! I moved to a new branch here and I'll finish this up #1443 I found out we can still use inline params in the new driver: https://github.com/databricks/databricks-sql-python/blob/main/docs/parameters.md#using-inline-parameters |
Moved to #1443 |
Description
Fix error in parsing results back from the underlying databricks sql client by updating dependencies.
Related Issues
Additional Context
https://dlthub-community.slack.com/archives/C04DQA7JJN6/p1716857509703029