[experiment] ibis integration with connection sharing #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sh-rp
changed the title
1 task
|
For reference, issue for connection sharing in ibis: ibis-project/ibis#8877 |
rudolfix
force-pushed
the
devel
branch
2 times, most recently
from
2ee3eab to
e48f641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has a connection borrowing approach which theoretically would make the integration quite easy with the wrapping contextmanager suggested here. Ibis does not have support for sharing an open dbapi connection so there is some hackery here and this does not work for most destinations unfortunately. Also about half of our sql destinations are not really supported by ibis.
The current test in here only passes for duckdb, postgres and snowflake. There are various problems on other destinations, that may or may not stem from some init code in the ibis backend not being run which would ordinarily run when executing the do_connect method.
Some notes: