Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_delta_tables helper function #1664

Merged
merged 14 commits into from
Aug 9, 2024
Merged

Add get_delta_tables helper function #1664

merged 14 commits into from
Aug 9, 2024

Conversation

jorritsandbrink
Copy link
Collaborator

@jorritsandbrink jorritsandbrink commented Aug 5, 2024 •
edited
Loading

Description

  • adds get_delta_tables helper function
  • adds two public methods on Pipeline class (needed the functionality for get_delta_tables and figured they're probably more broadly applicable):
    • get_last_completed_load_id
    • list_loaded_tables_names
  • adds new class DeltaReferenceFollowupJob(ReferenceFollowupJob)
    • changes the file extension for Delta reference jobs to reference_delta to distinguish them from "regular reference jobs"
  • does some other small unrelated improvements

Related Issues

@jorritsandbrink jorritsandbrink added the enhancement New feature or request label Aug 5, 2024
@jorritsandbrink jorritsandbrink self-assigned this Aug 5, 2024
@jorritsandbrink jorritsandbrink linked an issue Aug 5, 2024 that may be closed by this pull request
Helper that returns delta tables created by pipeline as DeltaTable objects #1651
Closed
@netlify Netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 7c9b9f7
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66b36e3f0ec52b000818dc9f
😎 Deploy Preview https://deploy-preview-1664--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jorritsandbrink jorritsandbrink marked this pull request as ready for review August 5, 2024 14:49
sh-rp
sh-rp approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@sh-rp sh-rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rudolfix
rudolfix approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
note to myself: we should drop circular dependencies ie. Pipeline is imported in destinations which should be level-up in type hierarchy.

@rudolfix rudolfix merged commit 0e0e42f into devel Aug 9, 2024
53 of 54 checks passed
@rudolfix rudolfix deleted the feat/1651-helper-that-returns-delta-tables-created-by-pipeline branch August 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix rudolfix approved these changes

@sh-rp sh-rp sh-rp approved these changes

Assignees

@jorritsandbrink jorritsandbrink

Labels
enhancement New feature or request
Projects
dlt core library
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helper that returns delta tables created by pipeline as DeltaTable objects
3 participants
@jorritsandbrink @sh-rp @rudolfix