updates duckdb/motherduck load job, adds full ci for motherduck and updates docs #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
burnash
reviewed
Aug 8, 2024
| @@ -1,11 +1,10 @@ | |||
| --- | |||
| title: 🧪 MotherDuck | |||
| title: MotherDuck | |||
rudolfix
changed the title
sh-rp
reviewed
Aug 12, 2024
| qualified_table_name, threading.Lock() | ||
| ) | ||
| source_format = "read_parquet" | ||
| options = ", union_by_name=true" | ||
| elif self._file_path.endswith("jsonl"): | ||
| # NOTE: loading JSON does not work in practice on duckdb: the missing keys fail the load instead of being interpreted as NULL |
There was a problem hiding this comment.
Judging from the work on my datasets PR this is not or no longer true. I have a test there that migrates a table and it still works in duckdb with json and parquet.
sh-rp
reviewed
Aug 12, 2024
| # we will use a different pipeline with a separate schema but writing to the same dataset and to the same table | ||
| # the table schema is identical to the previous one with a single field ("time") added | ||
| # this will create a different order of columns than in the destination database ("time" will map to "_dlt_id") | ||
| # duckdb copies columns by column index so that will fail |
There was a problem hiding this comment.
I don't understand the last line, afaik you are testing the union_by_name here and this should NOT fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
read_jsonwithout using COPY FROM which allows skipping of the fields