Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sources and destinations to the top level #1750

Merged
merged 8 commits into from
Sep 11, 2024

Conversation

VioletM
Copy link
Contributor

@VioletM VioletM commented Aug 27, 2024

closes #1725

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit b5faf1c
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66e1549e7d4f740008343e96
😎 Deploy Preview https://deploy-preview-1750--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@VioletM VioletM added the documentation Improvements or additions to documentation label Aug 27, 2024
@VioletM VioletM requested review from akelad and mariarice15 August 27, 2024 16:44
@rudolfix rudolfix added the sprint Marks group of tasks with core team focus at this moment label Aug 28, 2024
@akelad
Copy link
Contributor

akelad commented Aug 28, 2024

The sources logo is the wrong colour in dark mode:

image

Also, it's still misaligned somehow in light mode 🤔
image

I think no point in spending too much time on that yourself, either we get Anton to figure it out or we involve Elise or someone

item => item.label !== '30+ SQL Databases' && item.label !== 'REST API generic source'&& item.label !== 'Filesystem'
)} />

### What's the difference?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe say "What's the difference between core and verified sources?" just to be super clear

mariarice15
mariarice15 previously approved these changes Aug 28, 2024
Copy link
Contributor

@mariarice15 mariarice15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing is maybe move 'custom destination' into a tip, like it is under sources. Otherwise, it may look like the users have to pick one from the list, and we don't support anything else.

@VioletM
Copy link
Contributor Author

VioletM commented Aug 29, 2024

I think no point in spending too much time on that yourself

I already spent some time on it, so I think I know how to change it :)

@VioletM VioletM force-pushed the docs/move_sources_and_destinations branch from e70badc to b5faf1c Compare September 11, 2024 08:28
@akelad akelad merged commit bc99c93 into devel Sep 11, 2024
49 checks passed
@burnash burnash deleted the docs/move_sources_and_destinations branch September 11, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation sprint Marks group of tasks with core team focus at this moment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs | New top-level structure for sources
5 participants