-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added deploy with modal. #1805
Added deploy with modal. #1805
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
0333c54
to
8a49dce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good content, @dat-a-man. I've added some suggestions to improve the style.
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
2ee3eab
to
e48f641
Compare
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dat-a-man thanks for the updates, please see my review comments
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-modal.md
Outdated
Show resolved
Hide resolved
…lt-hub/dlt into docs/how-to-deploy-using-modal
docs/website/docs/walkthroughs/deploy_a_pipeline/deploy-with-modal-snippets.py
Outdated
Show resolved
Hide resolved
|
||
### How does dlt integrate with Modal for pipeline orchestration? | ||
|
||
As an example of how to set up a pipeline in Modal, we'll use the [building a cost-effective analytics stack with Modal, dlt, and dbt.](https://modal.com/blog/analytics-stack) case study. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably can remove this line and just link to the blog post at the end for a more "real world" example, since we've written the snippet to be a more runnable example.
left a few tiny comments, but any other hold up here? would love to get this published soon! |
…w-to-deploy-using-modal # Conflicts: # dlt/cli/deploy_command.py # poetry.lock
@kning hey Kenny! Everything is ready to be merged, we just need modal token for tests, is it possible to run it without token? does this token expire? how often we should refresh token? can we do that automatically? Can you help us with it? In current implementation we only run snippet as a python script via pytest, I added simple test inspired by this example |
you need to create a modal account / token for yourself, we actually have a guide for this: https://modal.com/docs/guide/continuous-deployment. fwiw, i wouldn't consider that blocking if it's too much work for now i know you've been working hard on this for a long time and i can always help you figure out the ci / cd modal part later. |
@kning let's move this conversation in our slack :D I contact you there, I think it will help us to solve this problem faster |
…w-to-deploy-using-modal
…w-to-deploy-using-modal # Conflicts: # poetry.lock
woohoo! i don't see it on the docs website yet though is there a separate deploy process? |
@kning You can see it in devel version here (it will be publish in main documentation with next release) https://dlthub.com/docs/devel/walkthroughs/deploy-a-pipeline/deploy-with-modal |
great! reading this there are some parts of the modal API (e.g. proxy, etc.) that have updated, i can go ahead and open a pr later. |
Description
Added deploy with modal