Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deploy with modal. #1805

Merged
merged 45 commits into from
Nov 7, 2024
Merged

Added deploy with modal. #1805

merged 45 commits into from
Nov 7, 2024

Conversation

dat-a-man
Copy link
Collaborator

Description

Added deploy with modal

@dat-a-man dat-a-man self-assigned this Sep 13, 2024
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit c97e935
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/672b9b743cba580008a2eca2
😎 Deploy Preview https://deploy-preview-1805--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dat-a-man dat-a-man added the documentation Improvements or additions to documentation label Sep 13, 2024
@dat-a-man dat-a-man force-pushed the docs/how-to-deploy-using-modal branch 2 times, most recently from 0333c54 to 8a49dce Compare September 16, 2024 08:27
@dat-a-man dat-a-man assigned adrianbr and unassigned adrianbr Sep 16, 2024
@dat-a-man dat-a-man requested a review from adrianbr September 16, 2024 09:30
@dat-a-man dat-a-man requested a review from burnash September 16, 2024 09:34
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good content, @dat-a-man. I've added some suggestions to improve the style.

@dat-a-man dat-a-man requested a review from burnash September 16, 2024 11:08
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dat-a-man thanks for the updates, please see my review comments


### How does dlt integrate with Modal for pipeline orchestration?

As an example of how to set up a pipeline in Modal, we'll use the [building a cost-effective analytics stack with Modal, dlt, and dbt.](https://modal.com/blog/analytics-stack) case study.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably can remove this line and just link to the blog post at the end for a more "real world" example, since we've written the snippet to be a more runnable example.

@kning
Copy link
Contributor

kning commented Oct 21, 2024

left a few tiny comments, but any other hold up here? would love to get this published soon!

@AstrakhantsevaAA
Copy link
Contributor

AstrakhantsevaAA commented Oct 22, 2024

@kning hey Kenny! Everything is ready to be merged, we just need modal token for tests, is it possible to run it without token? does this token expire? how often we should refresh token? can we do that automatically? Can you help us with it?

In current implementation we only run snippet as a python script via pytest, I added simple test inspired by this example

@kning
Copy link
Contributor

kning commented Oct 22, 2024

you need to create a modal account / token for yourself, we actually have a guide for this: https://modal.com/docs/guide/continuous-deployment. fwiw, i wouldn't consider that blocking if it's too much work for now i know you've been working hard on this for a long time and i can always help you figure out the ci / cd modal part later.

@AstrakhantsevaAA
Copy link
Contributor

@kning let's move this conversation in our slack :D I contact you there, I think it will help us to solve this problem faster

@sh-rp sh-rp merged commit f5a64be into devel Nov 7, 2024
60 of 61 checks passed
@sh-rp sh-rp deleted the docs/how-to-deploy-using-modal branch November 7, 2024 06:35
@kning
Copy link
Contributor

kning commented Nov 7, 2024

woohoo! i don't see it on the docs website yet though is there a separate deploy process?

@AstrakhantsevaAA
Copy link
Contributor

@kning You can see it in devel version here (it will be publish in main documentation with next release) https://dlthub.com/docs/devel/walkthroughs/deploy-a-pipeline/deploy-with-modal

@kning
Copy link
Contributor

kning commented Nov 7, 2024

great! reading this there are some parts of the modal API (e.g. proxy, etc.) that have updated, i can go ahead and open a pr later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants