Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add sftp option for filesystem source #1845

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Docs: Add sftp option for filesystem source #1845

merged 3 commits into from
Oct 1, 2024

Conversation

VioletM
Copy link
Contributor

@VioletM VioletM commented Sep 19, 2024

Closes #1836

@VioletM VioletM added the documentation Improvements or additions to documentation label Sep 19, 2024
@VioletM VioletM requested a review from burnash September 19, 2024 12:56
@VioletM VioletM self-assigned this Sep 19, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 4757831
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66fad405f120e00008a2c80c
😎 Deploy Preview https://deploy-preview-1845--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

burnash
burnash reviewed Sep 19, 2024
View reviewed changes
docs/website/sidebars.js Outdated Show resolved Hide resolved
burnash
burnash requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the update @VioletM. Please see a couple of suggestions mostly to make SFTP all caps

@VioletM VioletM force-pushed the docs/1836-add-filesystem-sftp branch from 474b2ec to 4757831 Compare September 30, 2024 16:38
@VioletM VioletM requested a review from burnash September 30, 2024 16:38
@VioletM VioletM merged commit 2eb8cfe into devel Oct 1, 2024
51 checks passed
@rudolfix rudolfix deleted the docs/1836-add-filesystem-sftp branch October 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burnash burnash burnash approved these changes

Assignees

@VioletM VioletM

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sftp configuration to filesystem source docs
2 participants
@VioletM @burnash