-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leverage ibis expression for getting readablerelations #2046
Merged
Merged
Changes from 9 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
8c111e9
add ibis dataset in own class for now
sh-rp f928279
make error clearer
sh-rp 4048b3c
fix some linting and fix broken test
sh-rp 830af97
make most destinations work with selecting the right db and catalog, …
sh-rp e289ad1
add missing motherduck and sqlalchemy mappings
sh-rp b6850e8
casefold identifiers for ibis wrapper calss
sh-rp 34323da
re-organize existing dataset code to prepare ibis relation integration
sh-rp 0eb6f58
integrate ibis relation into existing code
sh-rp c06525b
re-order tests
sh-rp 48e4034
fall back to default dataset if table not in schema
sh-rp 1fb17e0
make dataset type selectable
sh-rp f19a98d
add dataset type selection test and fix bug in tests
sh-rp acd329f
update docs for ibis expressions use
sh-rp afc2f06
ensure a bunch of ibis operations continue working
sh-rp 1375fb1
add some more tests and typings
sh-rp d92f2f1
fix typing (with brute force get_attr typing..)
sh-rp f22b1dc
move ibis to dependency group
sh-rp 7af8870
move ibis stuff to helpers
sh-rp 3bbad35
Merge branch 'devel' into exp/ibis_expressions
sh-rp e50b5b5
post devel merge, put in change from dataset, update lockfile
sh-rp 1ed3ff3
add ibis to sqlalchemy tests
sh-rp bedfb05
improve docs a bit
sh-rp ffb0ce1
fix ibis dep group
sh-rp 71dca18
fix dataset snippets
sh-rp 3886638
fix ibis version
sh-rp 289e289
add support for column schema in certion query cases
sh-rp 94fd4aa
Merge branch 'devel' into exp/ibis_expressions
rudolfix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we move
ibis
module to helpers? you are importing modules that are not in common. so we really need to refer to ibis in common?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that (see the commit) but there is one place in common where the IbisBackend typing is imported for the readable relation.