Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note for missing credentials error for windows authentication #2095

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

dat-a-man
Copy link
Collaborator

Description

Added note for missing credentials error for windows authentication

@dat-a-man dat-a-man added the documentation Improvements or additions to documentation label Nov 25, 2024
@dat-a-man dat-a-man requested a review from hibajamal November 25, 2024 08:32
@dat-a-man dat-a-man self-assigned this Nov 25, 2024
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit dc84e74
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6746f5a1433cde0008ebe426
😎 Deploy Preview https://deploy-preview-2095--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use admonitions markup for the notes: https://docusaurus.io/docs/markdown-features/admonitions

@@ -76,6 +76,8 @@ You can place any ODBC-specific settings into the query string or **destination.
destination.mssql.credentials="mssql://loader.database.windows.net/dlt_data?trusted_connection=yes"
```

`NOTE: If you encounter missing credentials errors when using Windows authentication, set the 'username' and 'password' as empty strings in the TOML file.`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Anton suggested:

:::note

If you encounter missing credentials errors when using Windows authentication, set the 'username' and 'password' as empty strings in the TOML file.

hibajamal
hibajamal previously approved these changes Nov 27, 2024
Copy link
Contributor

@hibajamal hibajamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dat-a-man
Copy link
Collaborator Author

@hibajamal updated as per comments.

@AstrakhantsevaAA AstrakhantsevaAA merged commit 63c9aa9 into devel Jan 2, 2025
49 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the docs/update_sql_server_docs branch January 2, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants