allows to apply table level hints via make_hints
#2365
Merged
+105
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
reviewed
Mar 3, 2025
| t.pop(k, None) # type: ignore[misc] | ||
| t.pop("additional_table_hints", None) # type: ignore | ||
| t["additional_table_hints"] = additional_table_hints | ||
| else: |
There was a problem hiding this comment.
So if additional_table_hints is set to {} then they are fully popped and if there is at least one item, then it gets merged into the existing values? is this the correct behavior?
There was a problem hiding this comment.
yes, all hints behave like this.
sh-rp
previously approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
makes
additional_table_hintspart ofTResourceHintswhich allows to update table-level hints dynamically