fixes schema merge behavior #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conflicts + tests
…ding default hints
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
reviewed
Sep 12, 2023
| @@ -66,7 +66,7 @@ def from_dict(cls, d: DictStrAny) -> "Schema": | |||
| # verify schema | |||
| utils.validate_stored_schema(stored_schema) | |||
| # add defaults | |||
| utils.apply_defaults(stored_schema) | |||
| stored_schema = utils.apply_defaults(stored_schema) | |||
There was a problem hiding this comment.
fyi this utils function changes the stored schema itself, not sure if you maybe wanted to clone it?
There was a problem hiding this comment.
no, it should happen in place
sh-rp
reviewed
Sep 12, 2023
| @@ -105,7 +105,7 @@ def start_file_load(self, table: TTableSchema, file_path: str, load_id: str) -> | |||
| def _get_column_def_sql(self, c: TColumnSchema) -> str: | |||
| hints_str = " ".join(self.active_hints.get(h, "") for h in self.active_hints.keys() if c.get(h, False) is True) | |||
| column_name = self.capabilities.escape_identifier(c["name"]) | |||
| return f"{column_name} {self._to_db_type(c['data_type'])} {hints_str} {self._gen_not_null(c['nullable'])}" | |||
| return f"{column_name} {self._to_db_type(c['data_type'])} {hints_str} {self._gen_not_null(c.get('nullable', True))}" | |||
There was a problem hiding this comment.
shouldn't the nullable always be set in columns that are complete?
There was a problem hiding this comment.
same question of course for all other destinations
There was a problem hiding this comment.
one of the changes is to not add all the possible hints with default values. in case of nullable we indeed make an exception - (see new_table) I'd need to investigate more. but I think this is OK for now
sh-rp
reviewed
Sep 12, 2023
sh-rp
reviewed
Sep 12, 2023
sh-rp
reviewed
Sep 12, 2023
sh-rp
reviewed
Sep 12, 2023
sh-rp
previously approved these changes
Sep 12, 2023
|
@sh-rp fixed the debug prints and merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description