Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for precision, scale in column schema #646

Merged
merged 20 commits into from
Sep 26, 2023

Conversation

steinitzu
Copy link
Collaborator

Description

WIP: Implement precision and scale hints for column schema.

Related Issues

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit d8b6ee1
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6512c29504498000085d40f2
😎 Deploy Preview https://deploy-preview-646--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@steinitzu steinitzu force-pushed the sthor/data-types-precision branch from a498163 to 3541919 Compare September 20, 2023 21:54
@steinitzu steinitzu changed the title One way support for precision, scale in column schema Support for precision, scale in column schema Sep 21, 2023
@steinitzu steinitzu force-pushed the sthor/data-types-precision branch from 2b671ef to c5ab62c Compare September 23, 2023 00:04
@steinitzu steinitzu force-pushed the sthor/data-types-precision branch from c5ab62c to e0f7097 Compare September 23, 2023 01:37
@steinitzu steinitzu marked this pull request as ready for review September 23, 2023 03:02
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good! thanks for a clean implementation (type mapper) and tests. I just added precision info to docs

@rudolfix rudolfix merged commit 2c6152e into devel Sep 26, 2023
@rudolfix rudolfix deleted the sthor/data-types-precision branch September 26, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] add precision and scale to applicable types
2 participants