[WIP] Synapse Destination #677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
reviewed
Oct 13, 2023
| @@ -10,6 +10,7 @@ | |||
| from dlt.destinations.sql_client import SqlClientBase | |||
| from dlt.destinations.job_impl import EmptyLoadJob | |||
| from dlt.destinations.job_client_impl import SqlJobClientWithStaging | |||
| from tests.utils import ACTIVE_DESTINATIONS | |||
There was a problem hiding this comment.
you can't imort test code into production code...
sh-rp
reviewed
Oct 13, 2023
| else: | ||
| # Replace the , with ; | ||
| insert_sql.append("".join(chunk).strip()[:-1] + ";\n") | ||
| if "synapse" in ACTIVE_DESTINATIONS: |
There was a problem hiding this comment.
if you need a different behavior here for synapse, you need to extend or replace this load job for synapse or somehow manage this with the capabilities object. this code is depended on some var that is only available in the test environment and will not work in production
sh-rp
reviewed
Oct 13, 2023
| if not tables: | ||
| return | ||
| # If a transaction is active, commit it | ||
| if not self._conn.autocommit: |
There was a problem hiding this comment.
i don't think you need this kind of code here. In which case is a transaction avtive when you drop the dataset?
sh-rp
reviewed
Oct 13, 2023
| def _drop_views(self, *tables: str) -> None: | ||
| # Save the current autocommit state | ||
| # If a transaction is active, commit it | ||
| if not self._conn.autocommit: |
sh-rp
reviewed
Oct 13, 2023
| def native_connection(self) -> pyodbc.Connection: | ||
| return self._conn | ||
|
|
||
| def drop_dataset(self) -> None: |
There was a problem hiding this comment.
why do you need to check if each table exists? can't you just drop all tables in the dataset like it is done in the mssql client?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the Synapse destination to the dlt destinations list.
This destination code is based off of the mssql destination, and makes the following changes:
INSERT INTOstatement) (Insert_job_client.py lines 62-104)Remaining Issues
Azure Blob Storage - We will need to implement method that lands data into Azure Blob Storage and utilizes COPY command to load the data into SQL pools: https://learn.microsoft.com/en-us/azure/synapse-analytics/sql/load-data-overview
Resolve error in tests:
String or binary data would be truncatedfor INSERT INTO queries that are inserting values over the max length of 4000Resolve error in tests :
Invalid object name '[TABLE]' (Table _is_ generated byCREATE TABLE` query but isn't recognized)Resolve Error in
test_data_writer_string_escapetest:Operation cannot be performed within a transactionResolve Error in
test_execute_dftest:Parse error at line: 1, column: 102: Incorrect syntax near ','