-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
credentials moved to configuration, added configuration pages #703
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Let's remove some of the remnants of the previous material. See my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the changes! It really gets better. I did a detailed reading and identified more things to improve so config docs are even more easy to understand.
docs/website/docs/general-usage/credentials/config_providers.md
Outdated
Show resolved
Hide resolved
docs/website/docs/general-usage/credentials/config_providers.md
Outdated
Show resolved
Hide resolved
docs/website/docs/general-usage/credentials/config_providers.md
Outdated
Show resolved
Hide resolved
docs/website/docs/general-usage/credentials/config_providers.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks to everyone working on this! already is great!
I left a few comments on built-in credentials. I can do a final touch @AstrakhantsevaAA if you have any doubts or missing information
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is good! I found one typo in config property name. I checked only the config_specs
document and from my side it is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! The update is much better. I've spotted a couple of minor things to fix. I believe it's good to go then.
docs/website/docs/general-usage/credentials/config_providers.md
Outdated
Show resolved
Hide resolved
docs/website/docs/general-usage/credentials/config_providers.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
* credentials moved to configuration, added configuration pages * add description * del description * fix paths * fix broken links * refactored secrets and configs * refactored config providers * refactored config specs * return "credentials" as a section slug * refactor links * updates config docs, requests changes * add built in creds * refactor specs * add explanation for secrets and config * refactor configuration * refactor configuration * move add creds to how to * convert comments to text * rename * del imports * Update docs/website/docs/walkthroughs/add_credentials.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/walkthroughs/add_credentials.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/config_providers.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/config_providers.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/config_providers.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/configuration.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/configuration.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/configuration.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/configuration.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/configuration.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/config_providers.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/config_providers.md Co-authored-by: Anton Burnashev <[email protected]> * add more details about secrets and config * intro for providers * intro for specs * small changes * spec examples with sources * small changes * delete link to name convention * refactor * refactor * refactor * refactor * fix typo * add info about home dir * Update docs/website/docs/general-usage/credentials/configuration.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/config_providers.md Co-authored-by: Anton Burnashev <[email protected]> * Update docs/website/docs/general-usage/credentials/config_specs.md Co-authored-by: Anton Burnashev <[email protected]> * wip * more info about Configuration classes * more about tomls * fix link * fix layout --------- Co-authored-by: Marcin Rudolf <[email protected]> Co-authored-by: Anton Burnashev <[email protected]>
Description
Configuration section docs
The whole info was took from current write-up:
https://github.com/dlt-hub/dlt/blob/devel/docs/technical/secrets_and_config.md
Related Issues
secrets
andconfiguration
doc #506