Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credentials moved to configuration, added configuration pages #703

Merged
merged 53 commits into from
Oct 31, 2023

Conversation

AstrakhantsevaAA
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA commented Oct 20, 2023

Description

Configuration section docs
The whole info was took from current write-up:
https://github.com/dlt-hub/dlt/blob/devel/docs/technical/secrets_and_config.md

Related Issues

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 5648034
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6541357cd6c965000867be21
😎 Deploy Preview https://deploy-preview-703--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Let's remove some of the remnants of the previous material. See my comments.

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes! It really gets better. I did a detailed reading and identified more things to improve so config docs are even more easy to understand.

docs/website/sidebars.js Show resolved Hide resolved
docs/website/sidebars.js Show resolved Hide resolved
docs/website/docs/general-usage/schema.md Outdated Show resolved Hide resolved
docs/website/docs/walkthroughs/add_credentials.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks to everyone working on this! already is great!
I left a few comments on built-in credentials. I can do a final touch @AstrakhantsevaAA if you have any doubts or missing information

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is good! I found one typo in config property name. I checked only the config_specs document and from my side it is OK.

rudolfix
rudolfix previously approved these changes Oct 30, 2023
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! The update is much better. I've spotted a couple of minor things to fix. I believe it's good to go then.

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@AstrakhantsevaAA AstrakhantsevaAA merged commit ad64a30 into devel Oct 31, 2023
36 of 39 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the docs/configuration branch October 31, 2023 17:17
AstrakhantsevaAA added a commit that referenced this pull request Nov 7, 2023
* credentials moved to configuration, added configuration pages

* add description

* del description

* fix paths

* fix broken links

* refactored secrets and configs

* refactored config providers

* refactored config specs

* return "credentials" as a section slug

* refactor links

* updates config docs, requests changes

* add built in creds

* refactor specs

* add explanation for secrets and config

* refactor configuration

* refactor configuration

* move add creds to how to

* convert comments to text

* rename

* del imports

* Update docs/website/docs/walkthroughs/add_credentials.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/walkthroughs/add_credentials.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/config_providers.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/config_providers.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/config_providers.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/configuration.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/configuration.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/configuration.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/configuration.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/configuration.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/config_providers.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/config_providers.md

Co-authored-by: Anton Burnashev <[email protected]>

* add more details about secrets and config

* intro for providers

* intro for specs

* small changes

* spec examples with sources

* small changes

* delete link to name convention

* refactor

* refactor

* refactor

* refactor

* fix typo

* add info about home dir

* Update docs/website/docs/general-usage/credentials/configuration.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/config_providers.md

Co-authored-by: Anton Burnashev <[email protected]>

* Update docs/website/docs/general-usage/credentials/config_specs.md

Co-authored-by: Anton Burnashev <[email protected]>

* wip

* more info about Configuration classes

* more about tomls

* fix link

* fix layout

---------

Co-authored-by: Marcin Rudolf <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] extend secrets and configuration doc
3 participants