Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set port correctly in mssql connection string #731

Merged
merged 2 commits into from
Nov 8, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix flaky sorting in arrow loading test
steinitzu committed Nov 6, 2023
commit 835c49c1119fff08dc4a6063a855627bc27fcc6e
8 changes: 6 additions & 2 deletions tests/load/pipeline/test_arrow_loading.py
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ def some_data():
assert some_table_columns["time"]["data_type"] == "time"

qual_name = pipeline.sql_client().make_qualified_table_name("some_data")
rows = [list(row) for row in select_data(pipeline, f"SELECT * FROM {qual_name} ORDER BY 1")]
rows = [list(row) for row in select_data(pipeline, f"SELECT * FROM {qual_name}")]

for row in rows:
for i in range(len(row)):
@@ -66,7 +66,7 @@ def some_data():
if isinstance(row[i], datetime):
row[i] = pendulum.instance(row[i])

expected = sorted([list(r.values()) for r in records], key=lambda x: x[0])
expected = sorted([list(r.values()) for r in records])

for row in expected:
for i in range(len(row)):
@@ -75,6 +75,10 @@ def some_data():

load_id = load_info.loads_ids[0]

# Sort rows by all columns except _dlt_id/_dlt_load_id for deterministic comparison
rows = sorted(rows, key=lambda row: row[:-2])
expected = sorted(expected)

for row, expected_row in zip(rows, expected):
# Compare without _dlt_id/_dlt_load_id columns
assert row[:-2] == expected_row