synapse: updated _insert function, escape chars (reset w/ devel) #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
eryanRM
changed the title
sh-rp
changed the title
sh-rp
reviewed
Nov 8, 2023
| # Then, call the parent class's __init__ method with the required arguments | ||
| super().__init__(table_name, file_path, sql_client) | ||
|
|
||
| def _insert(self, qualified_table_name: str, file_path: str) -> Iterator[List[str]]: |
There was a problem hiding this comment.
this is much better now, but my idea had been to hook into the _insert function of the superclass. the problem you have now is, that your implementation does not respect self._sql_client.capabilities.max_query_length and self._sql_client.capabilities.max_rows_per_insert. that's why I suggested to brancht out at "if max_rows is not None:" and not at the beginning of this method.
There was a problem hiding this comment.
@sh-rp Thanks for feedback -- apologies for not implementing your idea correctly. Is this better? Still WIP ... am I branching out correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Synapse destination integration
In addition to actioning earlier feedback, this PR condenses Synapse multi-row insert logic into '_insert' subclass
This replaces closed PR's: #708 and #725
Related Issues
Additional Context
Currently stalling on test: tests/load/pipeline/test_merge_disposition.py::test_merge_no_child_tables
VARBINARY(MAX) not working w/ Synapse column store tables
https://stackoverflow.com/questions/75517148/replacing-nvarcharmax-in-azure-synapse-table