Copy improvements in the SQL Database verified source #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
burnash
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Hey @anuunchin thanks for great work! I've gone through your changes and overall, it's shaping up really well. There are a few minor adjustments I've suggested in the comments which I believe could make this page even better. Keep up the great work!
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Anton Burnashev <[email protected]>
…nto website/docs/30-SQL-Databases
burnash
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Thank you @anuunchin for the contribution. I appreciate the attention to details. Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Included the info asked in the issue.
Made some additional wording improvements in the docs on the SQL Database verified source.
5th bullet point in the issue, namely, providing more info on how to create a connection string for a given dialect, is still to be resolved.
Related Issues
Additional Context
Will need more clarification regarding the 5th point.