Fixes typo in Incremental-loading docs. #774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstrakhantsevaAA
approved these changes
Nov 20, 2023
|
sorry, we had problems with CI/CD tests, so I had to steal your contribution, if you are in our slack community, then tell us your nickname, we will tag you in the next release announcement |
|
No worries, and don't worry about crediting me for this very tiny change. I hadn't used dlt before yesterday. If I decide to use it in some projects, I'll probably have reason to submit a more substantial contribution in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very small change.
private_keytoprimary_keyin the description of themergeoption forwrite_dispositionin the Incremental loading docs.Additional Context
While working through the Getting Started exercise, I was curious about the other
write_dispositionoptions, started reading the Incremental loading docs, and the description of themergeoption indicated it uses aprivate_keyto determine which records are duplicates. I'm nearly certain that should beprimary_keybased on semantics and exploring the codebase.