Docs/website/docs/examples/qdrant eg #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstrakhantsevaAA
requested changes
Nov 20, 2023
docs/examples/docs/examples/qdrant_zendeskdocs/examples/qdrant_zendesk/code/qdrant.py
Outdated
Show resolved
Hide resolved
docs/website/docs/examples/qdrant_zendesk/code/qdrant-snippets.py
Outdated
Show resolved
Hide resolved
docs/website/docs/examples/qdrant_zendesk/code/qdrant-snippets.py
Outdated
Show resolved
Hide resolved
burnash
previously requested changes
Nov 22, 2023
There was a problem hiding this comment.
Solid work @hibajamal! There are a few minor things that could be addressed for further improvement.
hibajamal
force-pushed
the
docs/website/docs/examples/qdrant_eg
branch
from
a6a7677 to
863a397
Compare
✅ Deploy Preview for dlt-hub-docs canceled.
|
hibajamal
force-pushed
the
docs/website/docs/examples/qdrant_eg
branch
5 times, most recently
from
acab09e to
038dd4f
Compare
docs/examples/docs/examples/qdrant_zendeskdocs/examples/qdrant_zendesk/code/qdrant.py
Outdated
Show resolved
Hide resolved
docs/website/docs/examples/qdrant_zendesk/code/qdrant-snippets.py
Outdated
Show resolved
Hide resolved
hibajamal
force-pushed
the
docs/website/docs/examples/qdrant_eg
branch
from
9664169 to
6aa5a68
Compare
rudolfix
previously requested changes
Dec 7, 2023
There was a problem hiding this comment.
@AstrakhantsevaAA @hibajamal thx for this! very neat example! please take a look at my review
docs/website/docs/examples/qdrant_zendesk/code/.dlt/secrets.toml
Outdated
Show resolved
Hide resolved
AstrakhantsevaAA
approved these changes
Dec 11, 2023
AstrakhantsevaAA
dismissed stale reviews from rudolfix and burnash
i don't want to bother him
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pushing the finalized Qdrant-zendesk code example.
Related Issues
Additional Context