Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents schema and data contract #782

Merged
merged 2 commits into from
Nov 23, 2023
Merged

documents schema and data contract #782

merged 2 commits into from
Nov 23, 2023

Conversation

rudolfix
Copy link
Collaborator

Description

Improves data contracts documentation. We still need good code examples how to apply them in a few interesting cases ie. schema inference and then contracts, pydantic models + event processing, contracts on arrow tables

@adrianbr @sh-rp please review. I'm happy to rewrite stuff to make it clearer

@rudolfix rudolfix added the devel label Nov 21, 2023
@rudolfix rudolfix requested review from sh-rp and adrianbr November 21, 2023 22:38
Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 277d931
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/655f4c24c09e520008afd514
😎 Deploy Preview https://deploy-preview-782--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rudolfix rudolfix self-assigned this Nov 21, 2023
# Conflicts:
#	dlt/common/schema/exceptions.py
#	tests/libs/test_pydantic.py
Copy link
Collaborator

@sh-rp sh-rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this looks very good! One thing we could consider is to mark experimental features better, i am not sure that this test tube symbol is universally understood.

@rudolfix rudolfix merged commit 0601d14 into devel Nov 23, 2023
33 of 39 checks passed
@rudolfix rudolfix deleted the rfix/contracts-docs branch November 23, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants