Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/test utils #795

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Fix/test utils #795

merged 4 commits into from
Dec 1, 2023

Conversation

AstrakhantsevaAA
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA commented Nov 29, 2023

Description

Fixes the make test-common failure due to a missing environment variable.

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 2c69cc2
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65686c0f1d200300083c02d3
😎 Deploy Preview https://deploy-preview-795--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! There's an extra space in the import, I've commented on it with a suggested change.

docs/website/docs/conftest.py Outdated Show resolved Hide resolved
@deanja deanja mentioned this pull request Nov 30, 2023
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AstrakhantsevaAA AstrakhantsevaAA merged commit 7a2f9c3 into master Dec 1, 2023
44 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the fix/test_utils branch December 1, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants