move all tests secrets to google vault #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
| @@ -9,6 +9,9 @@ on: | |||
| workflow_dispatch: | |||
|
|
|||
| env: | |||
|
|
|||
| DLT_SECRETS_TOML: ${{ secrets.DLT_SECRETS_TOML }} | |||
|
|
|||
| # all credentials must be present to be passed to dbt runner | |||
| DESTINATION__POSTGRES__CREDENTIALS: postgresql://[email protected]:5432/dlt_data | |||
| DESTINATION__REDSHIFT__CREDENTIALS: postgresql://[email protected]:5439/dlt_ci | |||
There was a problem hiding this comment.
why did you keep these creds for postgres and redshift?
There was a problem hiding this comment.
all credentials must be present to be passed to dbt runner
got it
There was a problem hiding this comment.
yeah, these have to be env vars, maybe there is a way we can load the toml file into the env for this, not sure.
There was a problem hiding this comment.
@AstrakhantsevaAA actually i misinterpreted the test, I could remove this after all
AstrakhantsevaAA
previously approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move away from github actions secrets to google secrets.