Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update field type coercion with more specific examples #883

Merged
merged 9 commits into from
Jan 9, 2024

Conversation

sultaniman
Copy link
Contributor

@sultaniman sultaniman commented Jan 9, 2024

In this PR I update column variance related type coercion and factors contributing related to introduction of a new column for the same field but with a different type.
Related to #881

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 0e77855
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/659d6b8caac5bd0008f1c5a8
😎 Deploy Preview https://deploy-preview-883--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sultaniman sultaniman requested a review from sh-rp January 9, 2024 14:20
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so good, @sultaniman
The only thing imo we can improve is to use a more descriptive name for the "name" column so make it super clear what's the table represents.

docs/website/docs/general-usage/schema.md Outdated Show resolved Hide resolved
docs/website/docs/general-usage/schema.md Show resolved Hide resolved
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sultaniman sultaniman changed the title WIP Update field type coercion with more specific examples Update field type coercion with more specific examples Jan 9, 2024
@sultaniman sultaniman merged commit 4d16a1f into devel Jan 9, 2024
38 checks passed
@sultaniman sultaniman deleted the dlt-issue-881 branch January 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants