-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Databricks destination #892
Merged
Merged
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
13e6a0e
Add escape_databricks_identifier function to
phillem15 6c3e8af
Add Databricks destination client and
phillem15 e941f4f
Refactor Databricks SQL client to use new API
phillem15 6bc1e4f
Refactor Databricks SQL client code
phillem15 8cd57b4
Refactor DatabricksCredentials configuration class
phillem15 d3dd5f5
Implement commit_transaction method in
phillem15 a2a53fc
Fix DatabricksCredentials host and http_path
phillem15 b630d31
Refactor DatabricksTypeMapper and
phillem15 c0ce477
Add support for secret string values in Databricks
phillem15 b85b930
Fix DatabricksSqlClient super call to use catalog
phillem15 f6aac09
Update Databricks credentials configuration
phillem15 f2ff181
Update Databricks destination capabilities and SQL
phillem15 1e9992d
Update file formats for Databricks staging
phillem15 60e9b8b
Refactored DatabricksSqlClient.has_dataset()
phillem15 f82bc53
Refactor DatabricksLoadJob constructor to improve
phillem15 640a04b
a few small changes
sh-rp 0d98248
Add and comment execute fragments method
phillem15 69404cc
Update staging file format preference
phillem15 635fd7e
Refactor execute_fragments method
phillem15 01604bb
Fix DatabricksLoadJob constructor arguments and
phillem15 d9fbcda
Update Databricks destination capabilities
phillem15 749aa11
Update Databricks destination code
phillem15 e0fdf3f
Fix SQL execution in SqlLoadJob
phillem15 8955cd9
Add SqlMergeJob to DatabricksLoadJob
phillem15 38357a8
Move databricks to new destination layout
steinitzu 058489c
Databricks dependency
steinitzu ed659f8
Add databricks destination_type
steinitzu 36d1718
Testing databricks with s3 staging
steinitzu ff7d7c0
Type mapping fixes for databricks
steinitzu 7dbd51e
Fix some databricks bugs
steinitzu ac916c8
Databricks parquet only
steinitzu efd965f
Init databricks ci
steinitzu f843731
Lint, cleanup
steinitzu 52ef939
Support databricks insert_values
steinitzu 4cd91a8
Databricks merge disposition support
steinitzu 444d196
Fix string escaping
steinitzu ed3d58b
Remove keep-staged-files option
steinitzu 1fcdb5d
Exceptions fix, binary escape
steinitzu e2c9aed
databricks dbt profile
steinitzu d6584d9
Handle databricks 2.9 paramstyle
steinitzu e63de19
Databricks docs
steinitzu dad726a
Remove debug raise
steinitzu 3fad7e4
Fix sql load job
steinitzu b3cb533
Revert debug
steinitzu 07a5eec
Typo fix
steinitzu a615a0a
General execute_many method in base sql client
steinitzu 051e9d3
Databricks client cleanup
steinitzu 64b7e2e
Implement staging clone table in base class
steinitzu 3076700
Personal access token auth only
steinitzu 0f32964
stage_name is not relevant
steinitzu 5d212a9
databricks jsonl without compression
steinitzu 1e548e0
Update jsonl in docs
steinitzu e8c08e2
Check and ignore empty json files in load job
steinitzu 2d50cc7
Cleanup
steinitzu dc984df
Update unsupported data types
steinitzu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sh-rp @rudolfix
Json support is even more limited. All these came up in
tests/load/pipeline/test_stage_loading.py::test_all_data_types
binary
in base64 does not work, not sure if it works at all in some other encoding.date
strings to timestamp and failsJSON
or equivelent type (I think), you need to create a struct column with a defined schema. And json objects/arrays don't convert automatically to stringThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definately think we should contact databricks about this and see what they say. @rudolfix who do we know there?