-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable async generators as resources #905
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
07fd59c
temp
sh-rp 8c8a94f
enable nested generator and add tests
sh-rp a07e37f
remove temp files
sh-rp e4ca5c3
convert async iterable to list of awaitables
sh-rp b8396a6
temp
sh-rp 79a42ed
update evaluation of round robin and fifo
sh-rp dbea27f
change limit behavior
sh-rp 28a6a12
small fixes
sh-rp 21c6db3
adds experiment for parallelizing regular resources
sh-rp a151428
fix linter
sh-rp 0211d3d
test is creating pool before iteration solves ci test problems
sh-rp c087ebf
make one test more predictable
sh-rp a7bf8e0
remove async pool fix
sh-rp 3c047a2
remove locks from generator wrappers
sh-rp 8d81d99
make test even more predictable
sh-rp 435239d
pr fixes
sh-rp 3787c63
fix async error test
sh-rp 05d0c55
update evaluation order tests
sh-rp 614b80b
adds sources at the end of pipe, closes generators before futures so …
rudolfix fb9c564
allows async generator items to be evaluated in add_limit
rudolfix 4a61e60
fixes tests
rudolfix 9446e29
update performance docs
sh-rp d830086
unrelated formatting fixes
sh-rp b844231
fix one test
sh-rp 568a2ce
small change to resource page
sh-rp 2a168e5
fixes tests
sh-rp 8cf3c3c
change generator exit test
sh-rp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works. the test fails now. The error on cancelling async gens is a cancellederror, not a generatorexit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh this was working for me. I was not cancelling async gen directly but the wrapped gen and propagating the exception. I'll check it out