fix bucket tests #918
Merged
fix bucket tests #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rudolfix
reviewed
Jan 30, 2024
| @@ -49,6 +68,7 @@ def assert_sample_files( | |||
| with file_dict.open() as f: | |||
| assert content == f.read() | |||
| # read via various readers | |||
| print(item) | |||
There was a problem hiding this comment.
@sh-rp @sultaniman please do not let debug prints into the devel. if this goes into release we'll need a quick post release to fix it. and this is PITA :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some new files in our test buckets that mess up the existing tests, so now we just make sure all the known files exist and can be accessed.