-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(airflow): implement parallel-isolated mode #979
Conversation
✅ Deploy Preview for dlt-hub-docs canceled.
|
@rudolfix, I'm not 100% sure I understood what you mean by dlt/dlt/helpers/airflow_helper.py Line 202 in cf2e886
It'll clone the pipeline, so seems to me it's what you mean by forking. Or maybe you mean that |
you are right! ticket was not clear. please take a look at updated requirements. also I added a requirement to add users if state is written in parallel mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! but spec was not clear so please see my comment...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have one issue (probably tickets were not clear). tests are really top!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IlyaFaer I changed the parallel mode to not run in separate pipeline names. I think the ticket was not clear. otherwise good. test that attach to all partial pipelines is cool
Towards: #931
Implements
parallel-isolated
decomposition mode.Made in about the same way as the
parallel
mode, but the first source component is executed in parallel with others.