-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [sql_database] Handle type ARRAY #547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this fix! Implementation itself is good and I expect it to work. Please see the review, tests should run automatically this time. Let's make sure that arrow backend also works...
0870857
to
b08c113
Compare
…ypes as it's now supported and we want to keep the test for pyarrow backend
b08c113
to
f186754
Compare
@vivingo are we able to push to your fork? we are happy to look at the tests and fix them |
@rudolfix yes, I enabled the "Allow edits by maintainers" checkbox. (I don't understand why my tests succeed when I test locally, sorry for that. I just pushed a new change but I guess I might have some further errors) |
@rudolfix any update on this ? |
Tell us what you do here
data_type
"complex"Short description
Type ARRAY (postgresql) was ignored and its
data_type
field was not filled.->
is_complete_column
(indlt.common.destination.reference
) isFalse
and we have a further error during the load as the column is not recognized.Related Issues
Additional Context
I only tried it with postgresql source and I hope this will not break other sources, but sqlalchemy's ARRAY Class documentation says (
sqlalchemy.sql.sqltypes.ARRAY
)Also I thought more logical to map it to "complex", like json types