-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics api #1162
Add metrics api #1162
Conversation
because of concurrency issues, we increment the metrics using redis atomic incrby. This means we have to store them in individual keys. Once we do this, we can set an expiration on each key to automatically delete old metrics.
I looked into the overhead of the function:
happy with that, will keep it as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
First step of enabling metrics collection.
Changes:
/metrics
endpoint: https://testing.dm3.network/ds/metrics