Skip to content

feat(check_for_request): inform number of concurrent pull requests #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcepl
Copy link
Contributor

@mcepl mcepl commented Apr 4, 2025

Fixes: #4

@mcepl mcepl force-pushed the check_for_request branch 2 times, most recently from 0957654 to 1029676 Compare April 4, 2025 09:50
@mcepl mcepl force-pushed the check_for_request branch from 1029676 to cfb5582 Compare April 4, 2025 10:11
@jubalh
Copy link

jubalh commented Apr 4, 2025

Should this not rather be post pull instead of pre push?
This way you might realize that someone already opened a PR for something that you want to do.

@mcepl
Copy link
Contributor Author

mcepl commented Apr 8, 2025

Perhaps both? check_for_request_on_action works for both, but that can be resolved by a simple symlink.

@dmach
Copy link
Owner

dmach commented Apr 14, 2025

@mcepl I suppose this requires unauthenticated access to the gitea instance, correct?
src.opensuse.org works nicely, but the internal instance errors out with {"message":"Only signed in user is allowed to call APIs."}

I'm thinking if shell scripts are a good idea after all.
Maybe we should keep them to handle the basic functionality of the drop-in directories for the hooks and then use python, which is a prerequisite for osc/git-obs anyway. And we could re-use some of the git-obs functionality incl. the configuration such as URLs, tokens, ssh keys etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hook as an equivalent of check_for_request_on_action = 1
3 participants