Skip to content

Commit

Permalink
Revert "Make sure Terminal Stable shows up default on 22544+" (micros…
Browse files Browse the repository at this point in the history
…oft#12664)

This reverts commit 457738e.
  • Loading branch information
DHowett authored Mar 10, 2022
1 parent b55f3ab commit 814386f
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions src/internal/stubs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,9 @@ void EdpPolicy::AuditClipboard(const std::wstring_view /*destinationName*/) noex

[[nodiscard]] HRESULT DefaultApp::CheckShouldTerminalBeDefault(bool& isEnabled) noexcept
{
// Since we toggled this feature on in Windows, Terminal (and Terminal Preview) need to
// agree -- otherwise, they will present UI that suggests Terminal is NOT the default,
// like the info bar.
OSVERSIONINFOEXW osver{};
osver.dwOSVersionInfoSize = sizeof(osver);
osver.dwBuildNumber = 22544;

DWORDLONG dwlConditionMask = 0;
VER_SET_CONDITION(dwlConditionMask, VER_BUILDNUMBER, VER_GREATER_EQUAL);

isEnabled = VerifyVersionInfoW(&osver, VER_BUILDNUMBER, dwlConditionMask) != FALSE;
// False since setting Terminal as the default app is an OS feature and probably
// should not be done in the open source conhost. We can always decide to turn it
// on in the future though.
isEnabled = false;
return S_OK;
}

0 comments on commit 814386f

Please sign in to comment.