fix resetting expanded for DefaultExpand::SearchResultsOrAll("")
#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apturing all path ids to reset
dmackdev
changed the title
DefaultExpand::SearchResultsOrAll("")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced in #44 whereby when using the
DefaultExpand::SearchResultsOrAll("")setting and changing the search term between empty and a search term that matched nothing, not all arrays/objects were being expanded.This was due to not traversing the entire JSON value and capturing all JSON path IDs in the
DefaultExpand::SearchResultsOrAll("")case, so not all arrays/objects had their open/closed state reset.