Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh improvements #1055

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ssh improvements #1055

wants to merge 2 commits into from

Conversation

MaxMatti
Copy link

@MaxMatti MaxMatti commented Dec 17, 2023 •
edited
Loading

zaneb
zaneb reviewed Feb 12, 2024
View reviewed changes
libvirt/uri/ssh.go
@@ -133,6 +133,11 @@ func (u *ConnectionURI) dialSSH() (net.Conn, error) {
username = sshu
}

hostname, err := sshcfg.Get(u.Hostname(), "HostName")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get() doesn't return an error when the key is not found, so this will result in the hostname ~never being read from the URI directly (i.e. it will only work when there is an alias in ~/.ssh/config).

And yes, the username thing immediately above is also broken.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, #1059 fixes all of these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memetb memetb memetb left review comments

@zaneb zaneb zaneb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot connect to ipv6 address with explicitly specified port
3 participants
@MaxMatti @zaneb @memetb