Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Instance: grab timeout from instance config #37

Merged
merged 1 commit into from
May 9, 2024

Conversation

Theodlz
Copy link
Contributor

@Theodlz Theodlz commented May 9, 2024

The timeout was only read from the Kowalski(..., timeout=60) function arg and not from the multi instances config itself. This PR looks for the timeout from the instance config, then the args/kwargs, and then uses the default.

Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoughlin mcoughlin merged commit ee006b2 into dmitryduev:master May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants