Expose more of the fetch API #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for users who want to avoid the complexity of Servant
This gives advanced users the flexibility to implement more complex APIs, in the same way that `servant-client` exposes `HasClient`.
dmjio
approved these changes
Apr 17, 2025
|
For the record, there are separate fetch libraries that can be used, but I believe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed just now on Matrix.
For the type class, there's an argument for only exposing it through some internal module rather than from the top-level
Misomodule where it would clutter the haddocks with a pretty niche part of the API. I'll leave that up to @dmjio. Personally I'd seriously consider factoring out the whole fetch API in to a separate library, not tied to Miso, but that suggestion was, not unreasonably, firmly rejected.