Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Drop plot tree style support. #10989

Merged
merged 9 commits into from
Nov 30, 2024
Merged

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Nov 7, 2024

This is to avoid having two different plotting routines in XGBoost: #9925

  • Add support for with_stats in libxgboost to match the functionality of the R plot.

@trivialfis trivialfis marked this pull request as ready for review November 28, 2024 04:03
@trivialfis trivialfis changed the title [WIP][R] Drop plot tree style support. [R] Drop plot tree style support. Nov 28, 2024
@trivialfis
Copy link
Member Author

cc @david-cortes @mayer79

Copy link
Contributor

@david-cortes david-cortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivialfis trivialfis merged commit 5826b02 into dmlc:master Nov 30, 2024
26 of 30 checks passed
@trivialfis trivialfis deleted the plot-stats branch November 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants