[R] Drop support for text inputs. #11026
Open
+30
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-package/R/xgb.DMatrix.R
Outdated
| #' @param data Data from which to create a DMatrix, which can then be used for fitting models or | ||
| #' for getting predictions out of a fitted model. | ||
| #' | ||
| #' Supported input types are as follows:\itemize{ | ||
| #' \item `matrix` objects, with types `numeric`, `integer`, or `logical`. | ||
| #' \item `data.frame` objects, with columns of types `numeric`, `integer`, `logical`, or `factor`. | ||
| #' \item `data.frame` objects, with columns of types `numeric`, `integer`, `logical`, or `factor`} |
There was a problem hiding this comment.
Looks like we have a mixture of markdown ("-" for bullet points) and roxygen ("\itemize" for list and "\item" for each point).
Should ideally use only one format for a given function doc.
david-cortes
reviewed
Dec 2, 2024
| #' Instead, the format must be specified following the URI format, so the input to `data` should be passed | ||
| #' like this: `"file.csv?format=csv"` (or `"file.csv?format=csv&label_column=0"` if the first column | ||
| #' corresponds to the labels). | ||
| #' These are **not** supported by the `xgb.QuantileDMatrix`. |
There was a problem hiding this comment.
Suggested change
| #' These are **not** supported by the `xgb.QuantileDMatrix`. | |
| #' These are **not** supported by `xgb.QuantileDMatrix`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #9472
Most changes are related to the document since we still need the URI API for binary input.