SYCL. Add more test for sycl-objectives #11064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Dec 8, 2024
| return inv_idcg_.View(ctx->Device()); | ||
| // This function doesn't have sycl-specific implementation yet. | ||
| // For that reason we transfer data to host in case of sycl is used for propper execution. | ||
| return inv_idcg_.View(ctx->Device().IsSycl() ? DeviceOrd::CPU() : ctx->Device()); |
There was a problem hiding this comment.
Feel free to make suggestion on how we should structure the project in the future.
I have fixed linking issues, but some cuda tests still faille |
|
Hi @trivialfis, could you please relaunch cuda-ci? It looks like the failures are not related to PR content. |
|
Just saw it, restarted. |
|
trivialfis
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts more tests for sycl-objectives.