Avoid forced log in the DMatrix binary loader. #11080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cortes
reviewed
Dec 8, 2024
| @@ -103,8 +103,7 @@ test_that("xgb.DMatrix: saving, loading", { | |||
| on.exit(unlink(tmp_file)) | |||
| expect_true(xgb.DMatrix.save(dtest1, tmp_file)) | |||
| # read from a local file | |||
| expect_output(dtest3 <- xgb.DMatrix(tmp_file), "entries loaded from") | |||
| expect_output(dtest3 <- xgb.DMatrix(tmp_file, silent = TRUE), NA) | |||
| expect_output(dtest3 <- xgb.DMatrix(tmp_file), NA) | |||
There was a problem hiding this comment.
I think there's no need to remove these tests. Perhaps a new one could be added checking that there is no log when the setting is changed globally and arg. silent is not passed.
There was a problem hiding this comment.
Brought back the tests.
david-cortes
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #11075 .