Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce tweaking at deploy time #1570

Merged

Conversation

todor-ivanov
Copy link
Contributor

@todor-ivanov todor-ivanov commented Nov 28, 2024

Fixes: dmwm/WMCore#12182

Description:
With the current change we tartget to reduce the dependence on the old WMA_ENV_FILE ergo its tweaking at deploy time.

So far we are changing only the env. variables which we were keeping in the WMA_ENV_FILE only for backwords compatibility with the old rpm based agents and we do not touch any of the variables requiring WMCore code base change. We are moving the setup of those variables as early as possible in the container environment configuration.

Is it backward compatible:
NO

External dependencies && Related PRs:
This PR must go hand in hand with: dmwm/WMCore#12183

Copy link
Member

@mapellidario mapellidario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it's always better to set variables explicitly, it makes reading and using grep easier, and it improves portability to whatever new set of scripts way easier. thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WMAgent - Venv minor misconfigurations
2 participants