Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site.requireAccelerator #5174

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Site.requireAccelerator #5174

merged 2 commits into from
Oct 14, 2022

Conversation

novicecpp
Copy link
Contributor

Client side of dmwm/CRABServer#7422, part of dmwm/CRABServer#6989

Thanayut Seethongchuen added 2 commits September 29, 2022 15:16
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: failed
    • 5 warnings and errors that must be fixed
    • 1 warnings
    • 131 comments to review
  • Pycodestyle check: succeeded
    • 432 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABClient-PR-test/913/artifact/artifacts/PullRequestReport.html

belforte
belforte approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@belforte belforte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@belforte belforte merged commit 8b8f2a2 into dmwm:master Oct 14, 2022
@belforte
Copy link
Member

maybe I should have not merged ?
This change will require modification to REST as well :

Reason is: Excess keyword arguments, not validated kwargs='{'Site.requireAccelerator': '0'}'

I have broken submissions from repository Head :-(
(yeah, I can still checkout last working tag !)

@novicecpp
Copy link
Contributor Author

Sorry Stefano, I forget to put tag "Do not merge", and we need other GPU Params too.
I will revert it.

@belforte
Copy link
Member

no worry, I can look into my changes starting from v3.221004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belforte belforte belforte approved these changes

@mapellidario mapellidario Awaiting requested review from mapellidario

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@novicecpp @cmsdmwmbot @belforte