Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Site.acceleratorParams #5179

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

novicecpp
Copy link
Contributor

@novicecpp novicecpp commented Nov 24, 2022

Part of dmwm/CRABServer#6989
Server side: dmwm/CRABServer#7470

Add Site.acceleratorParams to allow user send GPU parameters as key/value.
Serializing dict to JSON string and sending it to the server. Only validate key/value on server's side.

Configuration Example:

config.Site.requireAccelerator = True
config.Site.acceleratorParams = {
    "CUDACapabilities": ["6.0", "6.1", "6.2", "7.0", "7.2", "7.5", "8.0", "8.6"],
    "CUDARuntime": "11.4",
    "GPUMemoryMB": 8000
}

@cmsdmwmbot

This comment was marked as outdated.

Copy link
Member

@belforte belforte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: failed
    • 5 warnings and errors that must be fixed
    • 1 warnings
    • 131 comments to review
  • Pycodestyle check: succeeded
    • 436 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABClient-PR-test/924/artifact/artifacts/PullRequestReport.html

@belforte
Copy link
Member

belforte commented Dec 5, 2022

@novicecpp shall we merge ?

@novicecpp
Copy link
Contributor Author

Sure.

@novicecpp novicecpp merged commit e87a05d into dmwm:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants