Fixes dmwm/WMCore#12187 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip marking build unstable in PR-Report
Added retry and sleep for mariadb
|
This isn't ready to merge yet. I will first change any git clones in the Jenkinsfiles to use d-ylee:fix-12187. I will also change the branch in Jenkins to use this branch as well. After merging, another PR will be made to have Jenkins use the main branch again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dmwm/WMCore#12187
The fixes here are coupled with changes in dmwm/CMSKubernetes#1568
Major Changes
Script locations
TestScripts, ContainerScripts, and the etc directory are now moved to the root directory. Original location of docker/wmcore-dev still exists, but will be deprecated in a future release
User Permissions
wmcore-pr-test and wmcore-unittests are now run as the main user, not root user. As a result, a new directory, $WORKSPACE/home is added. It is bind mounted to /home/cmsbld in images to avoid some permissions/chown operations
Service Deployment
Most commands are now using
docker compose runinstead ofdocker compose exec. This, coupled with using thedepends_onin the compose files, seem to work fine. One future implementation would be to also give MariaDB a health check option, as indicated here: dmwm/WMCore#12198Versioning
This iteration of WMCore-Jenkins should be used with the
wmcore-dev:0.2.0-stableimage.