Skip to content

Commit

Permalink
Merge pull request #11489 from anehnis/patch-1
Browse files Browse the repository at this point in the history
Resolve Issue #11367
  • Loading branch information
amaltaro authored Feb 22, 2023
2 parents fea1de4 + f99df70 commit 747c70a
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions src/python/WMCore/MicroService/MSRuleCleaner/MSRuleCleaner.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,20 +302,6 @@ def _dispatchWflow(self, wflow):
msg = "Skipping cleanup step for workflow: %s - RequestType is %s."
msg += " Will try to archive it directly."
self.logger.info(msg, wflow['RequestName'], wflow['RequestType'])
elif wflow['RequestStatus'] in ['rejected', 'aborted-completed']:
# NOTE: We do not check the ParentageResolved flag for these
# workflows, but we do need to clean output data placement
# rules from the agents for them
for pline in self.agentlines:
try:
pline.run(wflow)
except Exception as ex:
msg = "%s: General error from pipeline. Workflow: %s. Error: \n%s. "
msg += "\nWill retry again in the next cycle."
self.logger.exception(msg, pline.name, wflow['RequestName'], str(ex))
continue
if wflow['CleanupStatus'][pline.name]:
self.wfCounters['cleaned'][pline.name] += 1
elif wflow['RequestStatus'] == 'announced' and not wflow['ParentageResolved']:
# NOTE: We skip workflows which are not having 'ParentageResolved'
# flag, but we still need some proper logging for them.
Expand All @@ -340,7 +326,7 @@ def _dispatchWflow(self, wflow):
msg += " Will retry again in the next cycle."
self.logger.info(msg)
self.alertStatusAdvanceExpired(wflow, additionalInfo=msg)
elif wflow['RequestStatus'] == 'announced':
elif wflow['RequestStatus'] in ['announced', 'rejected', 'aborted-completed']:
for pline in self.cleanuplines:
try:
pline.run(wflow)
Expand Down

0 comments on commit 747c70a

Please sign in to comment.