Exclude RequestStatus from the returned values of get_modifiable_properties #12108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amaltaro I think this may solve the probelm, but I still experience some issues with my |
|
Jenkins results:
|
|
Hi @amaltaro I just tested the fix - it's doing the job properly. we can safely merge this one |
|
@todor-ivanov it looks like we missed the the failing unit test: Please provide a new PR with the relevant fix (fixing the original issue 12107). |
|
This whole comment here was wrongly posted to the current PR. Now deleted and moved to: #12111 (comment) |
|
This whole comment here was wrongly posted to the current PR. Now deleted and moved to: #12111 (comment) |
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12037
Status
Ready
Description
with the current change we remove the
RequestStatuskey from the returned values ofget_modifiable_properties. this should avoid the conflict created between the set of values checked during the validation and the set of values supported in the WEB interface (the number of visualized keys in the web interface).Is it backward compatible (if not, which system it affects?)
YES
Related PRs
A Fix of a bug eventually introduced with: #12077
External dependencies / deployment changes
No