Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test threading monitor #12122

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix unit test threading monitor #12122

merged 1 commit into from
Sep 30, 2024

Conversation

khurtado
Copy link
Contributor

Fixes #12109

Status

ready

Description

Change threading.Thread().isAlive method to threading.Thread().is_alive, which is compatible with python 3.6.8->3.9.

Is it backward compatible (if not, which system it affects?)

YES

@khurtado khurtado requested a review from amaltaro September 30, 2024 13:54
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 22 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15256/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@amaltaro amaltaro merged commit 4924193 into dmwm:master Sep 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watchdog.IsAlive() does not work in python 3.9
3 participants