Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace xquery with query, due to deprecation of the former since HTCondor 10.7.0 #12158

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

khurtado
Copy link
Contributor

@khurtado khurtado commented Oct 24, 2024

Fixes #12027

Status

READY

Description

Replaces xquery with query. Arguments do not change.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

HTcondor python bindings

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 11 warnings
    • 102 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 14 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15378/artifact/artifacts/PullRequestReport.html

@khurtado
Copy link
Contributor Author

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
    • 11 warnings
    • 102 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 14 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15379/artifact/artifacts/PullRequestReport.html

@khurtado khurtado requested a review from amaltaro October 25, 2024 14:11
@khurtado
Copy link
Contributor Author

Tested with

https://cmsweb-testbed.cern.ch/reqmgr2/fetch?rid=amaltaro_TC_EL8_khurtado_tc_el8_v2_241024_214833_5767

This is still in running-closed, but not for condor reasons. I did not see any errors with condor submission.

drainAgent is the only script I have not tried, but since the xquery and query functions get the same arguments and the difference is the output (iterator vs list), I do not expect any issues.

@khurtado
Copy link
Contributor Author

test this please

1 similar comment
@khurtado
Copy link
Contributor Author

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 2 new failures
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
    • 11 warnings
    • 102 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 14 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15381/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks Kenyi!

@amaltaro amaltaro merged commit 76fd3a9 into dmwm:master Oct 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedd.xquery() has been deprecated in HTCondor 10.7.0
3 participants